fix(doctor): include ui_keymap in doctor output#7
fix(doctor): include ui_keymap in doctor output#7ChenMiaoi merged 2 commits intoChenMiaoi:developfrom
Conversation
- print the active ui_keymap value in criew doctor so users can verify their config file keymap setting is loaded correctly Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- add config_get_ui_keymap_returns_current_value to verify palette reports the active keymap value correctly - add loaded_vim_keymap_drives_navigation_keys to verify vim-mode j/k navigation and confirm default-mode i key does not trigger movement Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
I’ve tested this PR and it works well. One small suggestion: it might be helpful to display the selected keymap model in the top panel so users can easily see which model is currently selected. Of course, if you think there’s a better place to show it, feel free to go with what you think works best. 
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
2 participants
Summary
print the active ui_keymap value in criew doctor so users can verify their config file keymap setting is loaded correctly
Related Issues
Link issues if applicable.
What Changed
Testing
List what you ran locally.
Documentation
Checklist
Notes For Reviewers
Anything that needs special attention during review.