Skip to content

[Feat] configurable-main-page-keymaps#9

Merged
ChenMiaoi merged 2 commits intoChenMiaoi:developfrom
zevorn:feat/configurable-main-page-keymaps
Mar 9, 2026
Merged

[Feat] configurable-main-page-keymaps#9
ChenMiaoi merged 2 commits intoChenMiaoi:developfrom
zevorn:feat/configurable-main-page-keymaps

Conversation

@zevorn
Copy link
Contributor

@zevorn zevorn commented Mar 9, 2026

Summary

Feat/configurable-main-page-keymaps

Related Issues

Link issues if applicable.

What Changed

  • split background-sync TUI regression coverage out from the feature implementation commit
  • add manual-sync state-machine coverage for duplicate requests, busy workers, failures, disconnects, and completion refresh
  • add non-blocking mailbox-open, sync palette dismissal, and footer progress rendering coverage for startup, manual, and auto-sync states

Testing

List what you ran locally.


Documentation

  • No documentation change needed
  • README updated
  • Config / workflow docs updated
  • Other docs updated

Checklist

  • The change is focused on one topic
  • Commit messages follow the repository convention
  • Tests were added or updated when needed
  • User-visible behavior was documented when needed
  • I checked for regressions in related workflows

Notes For Reviewers

Anything that needs special attention during review.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 83.57488% with 68 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ui/tui.rs 82.42% 68 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ChenMiaoi ChenMiaoi changed the title Feat/configurable-main-page-keymaps [Feat] configurable-main-page-keymaps Mar 9, 2026
@ChenMiaoi
Copy link
Owner

@codex

@ChenMiaoi
Copy link
Owner

ChenMiaoi commented Mar 9, 2026

I test this function, it works well. But I think put the sync rendering at top right may better.

image

It seems too snarrow.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

zevorn added 2 commits March 9, 2026 22:35
- queue palette and mailbox-open sync requests onto background workers so the TUI stays responsive
- close the command palette after sync commands are queued so status updates remain visible on the main screen
- render footer sync progress for startup, manual, and auto-sync states so users can track background activity

Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- split background-sync TUI regression coverage out from the feature implementation commit
- add manual-sync state-machine coverage for duplicate requests, busy workers, failures, disconnects, and completion refresh
- add non-blocking mailbox-open, sync palette dismissal, and footer progress rendering coverage for startup, manual, and auto-sync states

Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
@zevorn zevorn force-pushed the feat/configurable-main-page-keymaps branch from eaf2a21 to a74fee8 Compare March 9, 2026 14:37
@zevorn
Copy link
Contributor Author

zevorn commented Mar 9, 2026

I test this function, it works well. But I think put the sync rendering at top right may better.

image It seems too snarrow.

You are right. I changed it.

Copy link
Owner

@ChenMiaoi ChenMiaoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenMiaoi ChenMiaoi merged commit 33de889 into ChenMiaoi:develop Mar 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants