Skip to content

Conversation

@GeorgeDong32
Copy link
Collaborator

What this PR does

Before this PR:

  • Code tools didn't support custom Anthropic and OpenAI-Response providers.
  • Codex used different config handling and lacked a --config option.
  • OpenAI Codex config parameters were incorrect.

After this PR:

  • Add support for custom Anthropic and OpenAI-Response providers in code.
  • Introduce and a --config option codex.
    Fix OpenAI Cod configuration parameter handling.

Fixes #12496,#12497

Why we need it and why it was done in this way

The following tradeoffs were made:

  • Ensures broader provider compatibility while keeping config handling explicit via --config.

The following alternatives were considered:

  • Inline config changes instead of adding --config, but --config keeps usage clearer.

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

  • None expected; changes are backward-compatible config and provider support enhancements.

Special notes for your reviewer

  • Verify custom provider flows for Anthropic and OpenAI-Response.
  • Check codex --config behavior and OpenAI Codex parameter correctness.

Checklist

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and keep it simple
  • Refactor: Left the code cleaner than found it
  • Upgrade: Impact on upgrade flows considered if required
  • Documentation: User-guide update considered if required

Release note

Support custom Anthropic and OpenAI-Response providers for code tools; add --config option to codex; fix OpenAI Codex config parameters.

@GeorgeDong32 GeorgeDong32 marked this pull request as ready for review January 17, 2026 16:21
@GeorgeDong32 GeorgeDong32 marked this pull request as draft January 17, 2026 16:21
@GeorgeDong32 GeorgeDong32 linked an issue Jan 18, 2026 that may be closed by this pull request
5 tasks
@GeorgeDong32 GeorgeDong32 changed the title fix/code-tools-custom-provider-support fix(code-tools): support custom provider & fix Windows Terminal Issue Jan 18, 2026
@GeorgeDong32 GeorgeDong32 force-pushed the fix/code-tools-custom-provider-support branch 2 times, most recently from 5396137 to e636150 Compare January 18, 2026 12:44
@GeorgeDong32 GeorgeDong32 marked this pull request as ready for review January 18, 2026 12:44
@GeorgeDong32 GeorgeDong32 requested review from DeJeune, EurFelux, beyondkmp, defi-failure and kangfenmao and removed request for kangfenmao January 18, 2026 14:10
@DeJeune DeJeune added this to the v1.7.14 milestone Jan 20, 2026
@GeorgeDong32 GeorgeDong32 force-pushed the fix/code-tools-custom-provider-support branch from e636150 to 3925b94 Compare January 21, 2026 05:09
@kangfenmao kangfenmao merged commit c03475f into main Jan 22, 2026
3 checks passed
@kangfenmao kangfenmao deleted the fix/code-tools-custom-provider-support branch January 22, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants