fix: memoize provider selectors to prevent infinite re-renders #12550
+28
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
useProvider,useAllProviders,useSystemProviders,useUserProviderswould receive new object references on every render due tonormalizeProvider()creating new objects insideuseAppSelectorcallbacksuseEffectdependenciesAfter this PR:
createSelectorfrom Redux ToolkitFixes the regression introduced in 8186d4f
Why we need it and why it was done in this way
The following tradeoffs were made:
createSelectorfor memoization instead ofuseMemoinside each hook, which is more efficient and follows Redux best practicesThe following alternatives were considered:
useMemoinside each hook - rejected becausecreateSelectorprovides better memoization at the selector levelnormalizeProvidercall entirely - rejected because trailing slash normalization is still neededBreaking changes
None. This is a bug fix that restores the expected behavior.
Special notes for your reviewer
The key insight is that
.map(normalizeProvider)insideuseAppSelectorcreates new object references on every render. Moving this intocreateSelectorensures the result is memoized and only recalculated when the input providers array changes.Checklist
Release note
🤖 Generated with Claude Code