Skip to content

Comments

fix(openclaw): resolve installation failure on Windows with spaces in path#12977

Merged
kangfenmao merged 1 commit intomainfrom
fix/openclaw-install-spaces
Feb 21, 2026
Merged

fix(openclaw): resolve installation failure on Windows with spaces in path#12977
kangfenmao merged 1 commit intomainfrom
fix/openclaw-install-spaces

Conversation

@GeorgeDong32
Copy link
Collaborator

What this PR does

Before this PR:

  • OpenClaw installation/uninstallation failed on Windows when the npm command path contained spaces (e.g., "C:\Program Files\nodejs\npm.cmd").

After this PR:

  • OpenClawService.install() and OpenClawService.uninstall() use spawn with shell: true when the npm path contains spaces, fixing the Windows installation failure.

Fixes #12945, #12935, #12963

Why we need it and why it was done in this way

  • Using spawn with shell:true for npm paths containing spaces ensures the command is executed correctly on Windows without changing crossPlatformSpawn or other callers.
  • Scope limited to install() and uninstall() to minimize impact.

Breaking changes

  • None.

Special notes for your reviewer

  • Change is minimal and targeted to OpenClawService install/uninstall logic.

Checklist

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: Left the code cleaner than you found it
  • Upgrade: Impact of this change on upgrade flows was considered
  • Documentation: No user-guide update required

Release note

fix(openclaw): handle npm paths with spaces on Windows during install/uninstall

@DeJeune DeJeune requested a review from EurFelux February 20, 2026 15:36
… path

Fixes issue #12945 where npm command path with spaces (e.g., C:\Program Files\nodejs\npm.cmd) was not properly handled during OpenClaw installation.

Changes:
- Use spawn with shell:true directly for npm paths containing spaces
- Only affects install() and uninstall() methods in OpenClawService
- Minimal impact scope, no changes to crossPlatformSpawn or other callers
@GeorgeDong32 GeorgeDong32 force-pushed the fix/openclaw-install-spaces branch from 85b2f1d to dff6b91 Compare February 20, 2026 15:58
@kangfenmao kangfenmao merged commit 9c44d45 into main Feb 21, 2026
8 checks passed
@kangfenmao kangfenmao deleted the fix/openclaw-install-spaces branch February 21, 2026 06:14
@dosubot
Copy link

dosubot bot commented Feb 21, 2026

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants