fix: force UTF-8 code page for OpenClaw gateway on Windows#13389
Open
fix: force UTF-8 code page for OpenClaw gateway on Windows#13389
Conversation
On Windows Chinese systems (CP936/GBK), the gateway's child processes output Chinese text in GBK encoding, causing garbled characters in chat responses. Prepend `chcp 65001` when spawning the gateway to force UTF-8 encoding for the entire process tree. Closes #13384 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
GeorgeDong32
left a comment
GeorgeDong32
left a comment
There was a problem hiding this comment.
Review Summary
This PR addresses two cross-platform compatibility issues effectively:
Changes Reviewed:
- Windows UTF-8 Encoding Fix: Using chcp 65001 to force UTF-8 code page before spawning the OpenClaw gateway on Windows
- Environment Variable Refactoring: Extracting gatewayEnv into a separate variable improves code clarity
- Import Cleanup: Combining type and function imports from child_process
Positives:
- Clean platform-specific handling using isWin check
- Good inline comment explaining the fix and referencing issue #13384
- Non-Windows platforms maintain existing behavior (backward compatible)
Suggestions:
- Consider adding explicit port validation before using this.gatewayPort in shell commands
- Testing on actual Windows Chinese systems would be valuable
Overall, this is a well-crafted fix that solves the reported encoding issue without introducing side effects.
Reviewed by kimi-k2.5
| import { hasAPIVersion, withoutTrailingSlash } from '@shared/utils' | ||
| import type { Model, Provider, ProviderType, VertexProvider } from '@types' | ||
| import type { ChildProcess } from 'child_process' | ||
| import { type ChildProcess, spawn } from 'child_process' |
Collaborator
There was a problem hiding this comment.
Nit: Good cleanup by importing directly alongside type. This avoids redundant import statements.
| let startupError: string | null = null | ||
| let processExited = false | ||
|
|
||
| const gatewayEnv = { ...shellEnv, OPENCLAW_CONFIG_PATH } |
Collaborator
There was a problem hiding this comment.
Positive: Good refactoring by extracting into a separate variable. This improves readability and ensures both Windows and non-Windows paths use the same environment configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chcp 65001when spawning the gateway on Windows to force UTF-8 code page for the entire process treeCloses #13384
Test plan