Open
Conversation
Collaborator
|
[!NOTE]
This comment was translated by Claude.
We can merge these skills first.
…---
<details>
<summary>Original Content</summary>
可以把这几个skill都先合进来
</details>
|
Collaborator
|
Note This issue/comment/review was translated by Claude. That's right, manage what's not shared separately. v2 needs to be unified, but after each module is completed, it should be standardized. Original Content是这样的，不共用的都各自管理，v2需要统一一下，不过各个模块都搞完之后应该都规范了 |
Collaborator
Author
|
Note This comment was translated by Claude.
Added. Original Content
加了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DeJeune @MyPrototypeWhat 大致先重构了一版UI，由于现在设置界面和设计稿不一致（不是弹窗），一些部分看起来有点奇怪(圆角之类的)，后面再改。
另外我觉得UI这部分整体的代码风格也可以统一一下，可以使用
vercel compostion pattern. 并且参考SelectionAssistantSettings将不共用的hooks和components各自管理，不要塞到renderer的hooks和components下