Skip to content

Add access to sympy Or #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmbader merged 7 commits into from
Feb 6, 2026
Merged

Add access to sympy Or #227

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bcf27e3
Add sympy Or to enable its usage in function arguments
nmbader Feb 5, 2026
556f5d3
fix the call to sympy Or
nmbader Feb 5, 2026
b85daf5
add unit test for sympy_or()
nmbader Feb 6, 2026
c5f3334
relax the unit test
nmbader Feb 6, 2026
0547f12
add @test_broken to sympy_or
nmbader Feb 6, 2026
e90f832
remove @test_broken
nmbader Feb 6, 2026
8b950ab
update ci.yml and if - else in sympy_or UT
nmbader Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Devito"
uuid = "06ed14b1-0e40-4084-abdf-764a285f8c42"
authors = ["Sam Kaplan <Sam.Kaplan@chevron.com>"]
version = "1.3.2"
version = "1.4.0"

[deps]
PyCall = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0"
Expand Down
5 changes: 4 additions & 1 deletion src/Devito.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ Symbol defining the size of the Dimension
function symbolic_size end

# metaprograming for Devito functions taking variable number of arguments
for (M,F) in ((:devito,:Min), (:devito,:Max),(:sympy,:And))
for (M,F) in ((:devito,:Min), (:devito,:Max), (:sympy,:And))
@eval begin
$F(args...) = $M.$F((PyObject.(args))...)
export $F
Expand Down Expand Up @@ -1559,6 +1559,9 @@ Perform Modular division on a dimension
Mod(x::Union{AbstractDimension,PyObject},y::Int) = sympy.Mod(PyObject(x),PyObject(y))
export Mod

"""function to return the sympy Or"""
sympy_or() = sympy.Or

"""Get symbolic representation for function index object"""
function Base.getindex(x::Union{TimeFunction,Function},args...)
return utils."indexobj"(x,reverse(args)...)
Expand Down
Loading