[CHIA-4278] Add WalletConnect fee estimation - #2834
Conversation
| } | ||
|
|
||
| async getFeeEstimate() { | ||
| return this.command<{ feeEstimate: number }>('get_fee_estimate'); |
There was a problem hiding this comment.
The above image is from getFeeEstimate of FullNode RPC API.
I'm not fully sure the new implementation you are going to add but are you sure you change the RPC interface for wallet service?
There was a problem hiding this comment.
Yes - currently that's the plan - though perhaps I shouldn't. I'll revisit this.
There was a problem hiding this comment.
Please ping me when you decide the spec of the API!
There was a problem hiding this comment.
Update: yes we are using a new Wallet implementation of getFeeEstimate not in the FullNode RPC API
9ba5c80 to
26b5fd3
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
ChiaMineJP
left a comment
ChiaMineJP
left a comment
There was a problem hiding this comment.
It seems chia-blockchain's main branch hasn't yet implemented get_fee_estimate Wallet RPC endpoint for now.
I think we should merge this into GUI's main after the app implements the RPC.
|
'This PR has been flagged as stale due to no activity for over 60 |
61aa59f to
0b922ce
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ebaee0e. Configure here.
danieljperry
changed the title
d075a06 to
ea5a23f
Compare
ChiaMineJP
left a comment
ChiaMineJP
left a comment
There was a problem hiding this comment.
You accidentally include package-lock.json so please remove from this PR.
ChiaMineJP
left a comment
ChiaMineJP
left a comment
There was a problem hiding this comment.
You deleted the package-lock.json but I wanted to remove changes in package-lock.json so that the file doesn't appear in this PR.
78839d1 to
335a633
Compare
|
@matt-o-how please resolve the comments for this PR. |
5 participants
This repository has access to calling the full node API, however this PR opts to implement the WalletConnect call through a new Wallet Node implementation added here
Note
Low Risk
Read-only wallet RPC with no signing or spending; exposure is limited to whitelisted WalletConnect/dapp paths similar to existing status queries.
Overview
WalletConnect and the GUI can request the wallet’s current fee-per-cost estimate via a new wallet RPC path, instead of routing fee estimation through the full node API.
WalletService.getFeeEstimate()callsget_fee_estimateand types the response as{ feePerCost }. The React layer exposesuseGetWalletFeeEstimateQuery(getWalletFeeEstimateon the wallet RTK slice). Electronchia_wallet.get_fee_estimateis registered with dapp aliaschia_getFeeEstimate(no params, confirmation bypass), and the command is on both the renderer allowlist and the dapp no-confirmation allowlist—aligned with other read-only wallet queries like peer count and sync status.Reviewed by Cursor Bugbot for commit c3db7eb. Bugbot is set up for automated code reviews on this repo. Configure here.