Wc client singleton and upgrade - #2911
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@SocketSecurity ignore npm/caniuse-lite@1.0.30001788 |
|
Please do not merge this until my large PR has been merged. |
|
'This PR has been flagged as stale due to no activity for over 60 |
Note
Medium Risk
Moderate risk because it changes WalletConnect client initialization/lifecycle and session proposal handling, which can affect pairing stability and dApp connectivity. Includes dependency upgrades that may introduce subtle protocol or storage behavior changes.
Overview
Updates the GUI’s WalletConnect integration to reuse a single
@walletconnect/sign-clientinstance via a global singleton, deduplicating concurrentClient.init()calls, warning on config mismatches, and clearing the WC IndexedDB storage on init failure.Adjusts event wiring and pairing flows to avoid stale closures (using refs) and updates session proposal handling to accept WalletConnect SDK changes by merging
requiredNamespacesandoptionalNamespaceswhen building approved namespaces.Reviewed by Cursor Bugbot for commit 9baa6f3. Bugbot is set up for automated code reviews on this repo. Configure here.