-
Notifications
You must be signed in to change notification settings - Fork 267
[CHIA-4324] NFT gallery: filter by preview availability #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlobue10
wants to merge
6
commits into
Chia-Network:main
Choose a base branch
from
jlobue10:nft-6-preview-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dad7bd6
Expose the cache's persisted state per URL to the renderer
jlobue10 ef63996
Add a preview-availability filter to the NFT gallery
jlobue10 b332522
Classify unmounted NFTs from their preview sources, not the data file…
jlobue10 95d0f69
Report preview availability from the verification state, not the rend…
jlobue10 862ce0c
Clear a refreshing NFT's preview verdict before the metadata round-trip
jlobue10 9212010
Keep a refresh from leaving stale preview verdicts behind
jlobue10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| enum NFTPreviewAvailability { | ||
| AVAILABLE = 'available', | ||
| UNAVAILABLE = 'unavailable', | ||
| ALL = 'all', | ||
| NONE = 'none', | ||
| } | ||
|
|
||
| export default NFTPreviewAvailability; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // Whether an NFT's gallery tile can show its media. UNAVAILABLE covers every | ||
| // placeholder a tile renders instead of content: no file to verify against, a | ||
| // file that failed to download, and a file that does not match its hash. | ||
| enum NFTPreviewStatus { | ||
| AVAILABLE = 'available', | ||
| UNAVAILABLE = 'unavailable', | ||
| } | ||
|
|
||
| export default NFTPreviewStatus; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| import type FileType from '../constants/FileType'; | ||
|
|
||
| type NFTsDataStatistics = Record<FileType | 'visible' | 'hidden' | 'total' | 'sensitive', number>; | ||
| type NFTsDataStatistics = Record< | ||
| FileType | 'visible' | 'hidden' | 'total' | 'sensitive' | 'previewAvailable' | 'previewUnavailable', | ||
| number | ||
| >; | ||
|
|
||
| export default NFTsDataStatistics; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.