update compute_additions_with_cost() to use run_puzzle() #16661
Conversation
…. This should make it more accurate with regards to the cost of conditions and possibly a little bit faster. It will now assume that the hard fork has activated, for purposes of validating the puzzle+solution and computing the cost of conditions
arvidn
added
the
Fixed
|
it seems we have a lot of tests exercising this function with invalid puzzles, and still expect to get the created coins returned.. |
|
the main challenge with this change is that we run unmatched offers to find their output coins, even though they are invalid. This change will just fail the whole puzzle rather than making a best-effort guess at what the output coins of a matched offer would be |
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
stale-pr
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
Purpose:
This should make it more accurate with regards to the cost of conditions and possibly a little bit faster. It will now assume that the hard fork has activated, for purposes of validating the puzzle+solution and computing the cost of conditions
Current Behavior:
new conditions like
SOFTFORKand the unknown condition codes with cost (introduced with the hard fork) are not taken into account when computing the cost.New Behavior:
The new conditions are taken into account (unconditionally) when computing the cost, as if the hard fork has activated.