Skip to content

add shielding #16875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

add shielding #16875

wants to merge 13 commits into from

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 19, 2023 •
edited
Loading

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

(async def [^(]*(close|stop)|except\b|finally:|suppress\()
^ *(async def [^(]*(close|stop)|(except|finally)\b)[^:]*:[^\n]*\n(?! *with anyio.CancelScope\(shield=True)

also the new chia dev check shielding command

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 21, 2023
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky mentioned this pull request Nov 22, 2023
Draft
2 tasks
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky self-assigned this Nov 27, 2023
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 5, 2023
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7848015569

  • -128 of 547 (76.6%) changed or added relevant lines in 48 files are covered.
  • 48 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-0.05%) to 90.823%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/timelord/timelord.py 8 9 88.89%
chia/util/db_wrapper.py 14 15 93.33%
chia/timelord/timelord_launcher.py 3 5 60.0%
chia/daemon/client.py 11 14 78.57%
chia/farmer/farmer_api.py 1 4 25.0%
chia/wallet/cat_wallet/cat_wallet.py 1 4 25.0%
chia/wallet/did_wallet/did_wallet.py 1 4 25.0%
chia/wallet/puzzles/prefarm/spend_prefarm.py 0 3 0.0%
chia/cmds/cmds_util.py 12 16 75.0%
chia/cmds/rpc.py 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
chia/data_layer/dl_wallet_store.py 1 95.74%
chia/data_layer/download_data.py 1 70.81%
chia/rpc/wallet_rpc_api.py 1 89.57%
chia/server/chia_policy.py 1 95.0%
chia/server/node_discovery.py 1 79.49%
chia/timelord/timelord_launcher.py 1 70.15%
chia/wallet/wallet_state_manager.py 1 96.33%
tests/core/server/test_loop.py 1 95.3%
tests/core/util/test_file_keyring_synchronization.py 1 97.1%
tests/fee_estimation/test_fee_estimation_unit_tests.py 1 99.06%
Totals Coverage Status
Change from base Build 7844390313: -0.05%
Covered Lines: 96874
Relevant Lines: 106615
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/check.py 53.8% lines 10, 15, 17-19, 21
chia/cmds/check_func.py 11.1% lines 8-9, 11-14, 16-17, 19-21, 23-27, 29-32, 34-38, 40, 42-46, 48
chia/cmds/cmds_util.py 83.3% lines 150, 238, 240-241
chia/cmds/rpc.py 16.7% lines 54-56, 78-79
chia/daemon/client.py 78.6% lines 230-232
chia/daemon/server.py 35.7% lines 337-340, 342-343, 345-347, 349, 395-397, 762-766
chia/data_layer/data_layer.py 55.6% lines 217, 219, 650-655
chia/data_layer/download_data.py 14.3% lines 199-201, 206-208
chia/farmer/farmer_api.py 25.0% lines 537, 539, 541
chia/full_node/full_node.py 68.2% lines 489, 619, 622-625, 1043-1045, 1805, 1808-1811, 2214-2216, 2218, 2352-2354
chia/introducer/introducer.py 40.0% lines 111-113, 116-118
chia/seeder/dns_server.py 3.3% lines 65-70, 72-74, 362-364, 379-388, 390-396
chia/server/ws_connection.py 84.1% lines 304-307, 630-632
chia/simulator/setup_services.py 75.0% lines 319-321, 325, 435-436, 475-476
chia/timelord/timelord.py 88.9% lines 187
chia/timelord/timelord_launcher.py 60.0% lines 149-150
chia/util/db_wrapper.py 93.3% lines 231
chia/wallet/cat_wallet/cat_wallet.py 25.0% lines 154-156
chia/wallet/did_wallet/did_wallet.py 25.0% lines 145-147
chia/wallet/puzzles/prefarm/spend_prefarm.py 0.0% lines 5, 89-90
chia/wallet/wallet_node.py 50.0% lines 1158-1161
Total Missing Coverage
606 lines 173 lines 71%

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@altendky altendky mentioned this pull request Nov 15, 2024
Draft
@altendky
Copy link
Contributor Author

closing in favor of #18874

@altendky altendky closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@altendky altendky

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes merge_conflict Branch has conflicts that prevent merge to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@altendky