Skip to content

Format DL cmd exceptions. #16939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Format DL cmd exceptions. #16939

wants to merge 4 commits into from

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Nov 28, 2023

Improves DL cmd traceback handling, by removing the special characters like \\n \\\\ \\\n which are probably leftover from JSON to str conversions. All common code between cmds is moved in the wrapper run_with_error_handling. This allows newlines to be parsed better.

@fchirica fchirica added DataLayer Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels Nov 28, 2023
@fchirica fchirica marked this pull request as ready for review November 30, 2023 01:13
@fchirica fchirica requested a review from a team as a code owner November 30, 2023 01:14
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Jan 14, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the stale-pr Flagged as stale and in need of manual review label Feb 15, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataLayer Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog merge_conflict Branch has conflicts that prevent merge to main stale-pr Flagged as stale and in need of manual review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant