Skip to content

remove contains height from BlocksProtocol #18573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

remove contains height from BlocksProtocol #18573

wants to merge 8 commits into from

Conversation

almogdepaz
Copy link
Contributor

@almogdepaz almogdepaz commented Sep 10, 2024 •
edited
Loading

Purpose:

remove contains height from blocks protocol

Current Behavior:

we are using contains height that checks the height_to_hash where we can check if height is <= peak.height

New Behavior:

add get_peak_height to BlocksProtocol and use that instead of contains_height

Testing Notes:

@almogdepaz almogdepaz added Blockchain team Issues tagged for Blockchain team to work on Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Cleanup Code cleanup labels Sep 10, 2024
@almogdepaz
update block cache on add block
15f9b21 
revert wallet change
@almogdepaz almogdepaz marked this pull request as ready for review September 10, 2024 10:12
@almogdepaz almogdepaz requested a review from a team as a code owner September 10, 2024 10:12
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Dec 1, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the stale-pr Flagged as stale and in need of manual review label Dec 3, 2024
@almogdepaz almogdepaz requested a review from arvidn December 3, 2024 11:22
@github-actions GitHub Actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Jan 24, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the stale-pr Flagged as stale and in need of manual review label Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn Awaiting requested review from arvidn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Blockchain team Issues tagged for Blockchain team to work on Cleanup Code cleanup Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog merge_conflict Branch has conflicts that prevent merge to main stale-pr Flagged as stale and in need of manual review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@almogdepaz