Catch assertion error in height_to_hash() #18667
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-o-how
added
the
Fixed
arvidn
reviewed
Oct 5, 2024
| height_hash: Optional[bytes32] = None | ||
| try: | ||
| height_hash = self.height_to_hash(peak_block.height) | ||
| except Exception: |
There was a problem hiding this comment.
It seems risky to catch (and ignore) all exceptions. This would include assertion failures.
I think it would be more precise to either check if the current chain has the block height we're about to look up.
|
|
now that we've realized that |
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Currently get_hash() in block_height_map.py has an assert which can fail and is not caught in the calling height_to_hash() function in blockchain.py.
In this case we should treat it as though we are on a fork that is further ahead than us.
This PR adds in try except condition, a default value, and a log for when this case is hit.
Current Behavior:
Raises the exception.
New Behavior:
Catches, logs and proceeds