Skip to content

[CHIA-1281] look-up generators in bulk (during reorg) #19477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Apr 8, 2025

Purpose:

Make potentially fewer DB queries for looking up generator references during reorgs (where they are looked up by block hash instead of height)

Current Behavior:

We look up generators one at a time.

New Behavior:

We look up all generators in one query.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Apr 8, 2025
Copy link

Pull Request Test Coverage Report for Build 14329159265

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 3 files are covered.
  • 18 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.295%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 85.07%
chia/_tests/core/full_node/stores/test_block_store.py 1 99.3%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/wallet/wallet_node.py 1 87.97%
chia/full_node/full_node.py 3 86.33%
chia/server/node_discovery.py 4 82.26%
chia/server/address_manager.py 7 91.38%
Totals Coverage Status
Change from base Build 14318635627: 0.02%
Covered Lines: 101413
Relevant Lines: 110941

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review April 8, 2025 09:49
@arvidn arvidn requested a review from a team as a code owner April 8, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant