Skip to content

CHIA-2681 Turn BundleCoinSpend into a frozen dataclass #19479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CHIA-2681 Turn BundleCoinSpend into a frozen dataclass #19479

wants to merge 1 commit into from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Apr 8, 2025
@AmineKhaldi AmineKhaldi self-assigned this Apr 8, 2025
@AmineKhaldi AmineKhaldi changed the title Turn BundleCoinSpend into a frozen dataclass CHIA-2681 Turn BundleCoinSpend into a frozen dataclass Apr 8, 2025
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 14331623581

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 21 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.309%
Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_node.py 1 87.9%
chia/plotters/bladebit.py 5 63.27%
chia/server/address_manager.py 7 90.31%
chia/server/node_discovery.py 8 81.18%
Totals Coverage Status
Change from base Build 14318635627: 0.03%
Covered Lines: 101416
Relevant Lines: 110928
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review April 8, 2025 13:03
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner April 8, 2025 13:03
@arvidn
Copy link
Contributor

arvidn commented Apr 9, 2025

we expect this to be slower, right?
I think this change needs some justification and maybe profiling.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog merge_conflict Branch has conflicts that prevent merge to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmineKhaldi @arvidn