Skip to content

catchup: into long_lived/datalayer_merkle_blob from main @ e81b213b9a7bb2a46539d2ef5ed1ed1cd9271345 #19614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: long_lived/datalayer_merkle_blob
Choose a base branch
from

Conversation

altendky
Copy link
Contributor

Source hash: e81b213
Remaining commits: 0

AmineKhaldi and others added 28 commits May 1, 2025 12:15
Optimize mempool's removals checking.
* improve dedup

* address review comments
* Backport enabling Keccak by default for wallet

* Keep ENABLE_KECCAK when not using mempool_mode
…nt/main_from_release_2.5.4_8ec82c578e3a98462b5a3e5cf5bf8fc5316f1358
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
…nt/main_from_release_2.5.4_5e0a0df94a261b84b6b940fd661c7be4b49f01a6
Improve dedup (#19565)

* improve dedup

* address review comments

Co-authored-by: Arvid Norberg <[email protected]>
…nt/main_from_release_2.5.4_0fb511b2f67d40a9499adce4eec2fda5d6464cea
Enable Keccak for 2.5.4 (#19563)

* Backport enabling Keccak by default for wallet

* Keep ENABLE_KECCAK when not using mempool_mode

Co-authored-by: Earle Lowe <[email protected]>
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
Bumps [lxml](https://github.com/lxml/lxml) from 5.3.2 to 5.4.0.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-5.3.2...lxml-5.4.0)

---
updated-dependencies:
- dependency-name: lxml
  dependency-version: 5.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…19590)

* Move `chia/types/spend_bundle.py` to wallet.

* Move `compute_additions` functions into wallet.

* Move `chia/types/eligible_coin_spends.py` to `chia/full_node`.
…nt/main_from_release_2.5.4_baceeb841754e5079df58257c2b3d1ba25c4d4c0
* Tighten chia_rs version spec

* avoid ^ due to poetry docs and be explicit
… block generator creation versions (#19585)

Adapt test_check_removals_with_block_creation to cover both block generator creation versions.
…nt/main_from_release_2.5.4_78ccd6988581a387e943e67e88dea68e471838bf
…long_lived_datalayer_merkle_blob_from_main_e81b213b9a7bb2a46539d2ef5ed1ed1cd9271345
@altendky altendky requested a review from a team as a code owner May 16, 2025 20:01
@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 16, 2025
@altendky altendky requested a review from a team as a code owner May 16, 2025 20:01
@altendky altendky removed request for a team May 20, 2025 17:27
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/dev/data.py 0.0% lines 52, 116-118, 141
chia/wallet/util/compute_additions.py 96.7% lines 32
Total Missing Coverage
344 lines 6 lines 98%

Copy link

Pull Request Test Coverage Report for Build 15143964504

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 338 of 344 (98.26%) changed or added relevant lines in 44 files are covered.
  • 49 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/util/compute_additions.py 29 30 96.67%
chia/cmds/dev/data.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
chia/daemon/server.py 1 83.46%
chia/plotters/plotters.py 1 90.94%
chia/_tests/simulation/test_simulation.py 1 97.76%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/cmds/dev/data.py 2 27.47%
chia/timelord/timelord.py 2 81.2%
chia/data_layer/data_layer.py 3 85.73%
chia/full_node/full_node.py 3 88.03%
chia/rpc/rpc_server.py 3 88.24%
chia/wallet/wallet_node.py 3 87.67%
Totals Coverage Status
Change from base Build 15074323106: 0.03%
Covered Lines: 100781
Relevant Lines: 110457

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants