Skip to content

Bump chia rs >=0.24, <0.25 #19615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025
Merged

Bump chia rs >=0.24, <0.25 #19615

merged 5 commits into from
May 29, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 19, 2025

These changes are best reviewed one commit at a time.

Purpose:

update chia_rs to get an updated ConsensusConstants that includes the hard fork related constants. as well as an update ProofOfSpace that defines the protocol for how to identify v2 plots.

The blockchain still only allows v1 plots and the hard fork is currently set to 0xffffffff as a placeholder.

Another big change in chia_rs was that it dropped the (circular) dependency on chia-blockchain. This required removing some methods on chia_rs.Program (known as SerializedProgram in this repo). This required a fairly large patch.

@arvidn arvidn requested a review from almogdepaz May 19, 2025 12:52
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 19, 2025
@almogdepaz almogdepaz mentioned this pull request May 19, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 23, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@arvidn arvidn force-pushed the bump-chia-rs branch 2 times, most recently from 023044a to 655f0df Compare May 27, 2025 23:14
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 27, 2025
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@arvidn arvidn marked this pull request as ready for review May 28, 2025 08:02
@arvidn arvidn requested review from altendky and a team as code owners May 28, 2025 08:02
@arvidn arvidn requested a review from almogdepaz May 28, 2025 09:50
almogdepaz
almogdepaz previously approved these changes May 28, 2025
@altendky altendky dismissed their stale review May 28, 2025 16:22

requested changes have been made

@altendky altendky changed the title Bump chia rs Bump chia rs >=0.24, <0.25 May 28, 2025
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, maybe we should just have a separate function or each type? *shrug*

almogdepaz
almogdepaz previously approved these changes May 28, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/wallet/db_wallet/test_db_graftroot.py 50.0% lines 147
chia/consensus/block_header_validation.py 66.7% lines 509
chia/simulator/wallet_tools.py 66.7% lines 167
chia/types/blockchain_format/proof_of_space.py 61.3% lines 26, 54-58, 60, 83-86, 88
Total Missing Coverage
194 lines 15 lines 92%

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Starttoaster Starttoaster merged commit c0410e9 into main May 29, 2025
883 of 902 checks passed
@Starttoaster Starttoaster deleted the bump-chia-rs branch May 29, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants