Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit be2a1d2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

DO NOT MERGE
Purpose:
Off by one for wallet race cache
Current Behavior:
Does not include fork point
New Behavior:
Includes fork point
Testing Notes:
Note
Medium Risk
Touches untrusted wallet sync/reorg edge cases and changes when cached coin states are (re)applied, which could affect transaction/notification handling if the new filtering is incorrect.
Overview
Fixes an off-by-one in untrusted wallet short-sync race-cache application by including the exact fork height when replaying cached
CoinStateupdates.Adds
PeerRequestCache.coin_state_validation_recorded()and uses it to skip already-recorded validations (including reorg markers), and prunes successfully-applied entries from_race_cacheto prevent coin states from being replayed afterclear_after_height()drops validation markers.Reviewed by Cursor Bugbot for commit fe0cbc5. Bugbot is set up for automated code reviews on this repo. Configure here.