Open
Conversation
Coverage Report for CI Build 24808455717Coverage decreased (-0.04%) to 91.188%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions63 previously-covered lines in 25 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Purpose:
Current Behavior:
New Behavior:
Testing Notes:
Note
Medium Risk
Touches untrusted wallet short-sync cache eviction logic; an off-by-one here can affect whether coin states are re-applied or dropped around reorg boundaries.
Overview
Fixes an off-by-one in untrusted close-to-peak syncing by changing
cleanup_race_cache()to retain entries starting atbacktrack_fork_height + 1after applying per-height race-cache updates, instead of including the fork height itself.Reviewed by Cursor Bugbot for commit 2b16846. Bugbot is set up for automated code reviews on this repo. Configure here.