add electron app - #403
Conversation
166068f to
796b781
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
Ignoring alerts on:
|
|
@SocketSecurity ignore npm/electron-winstaller@5.4.0 |
ef4abcb to
076e00d
Compare
9ccdec6 to
89ca783
Compare
2df1433 to
fea9fbc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fea9fbc. Configure here.

add electron




build Electron installers on macOS, Windows, and Linux in CI
Note
High Risk
Introduces a new security-critical desktop boundary (custom protocol, CSP, network policy, IPC, signing pipeline) and broad front-end behavior changes for Electron; mistakes could block hubs, wallets, or weaken isolation.
Overview
Adds a desktop package that wraps the existing player React + WASM bundle in a hardened Electron shell, with installers for macOS, Windows, and Linux.
The renderer is served from
chiagaming://app(notfile://), with sandboxing, CSP, hub/WebSocket/WalletConnect egress allowlists, runtime hub trust via a single IPC channel, and electron-builder fuses plus macOS entitlements. The front end branches on__chiaDistributionto hide the simulator, fix WalletConnect metadata for non-http origins, request hub trust before connecting, and treat orphaned tab leases as stale.CI adds a matrix workflow that builds WASM (including WASI SDK on macOS), optionally signs (Apple / DigiCert on non-PR builds), notarizes macOS DMGs, and uploads artifacts.
build.rsruns Chialisp compilation on a thread with a larger stack whenCHIALISP_COMPILEis set.Reviewed by Cursor Bugbot for commit 89ca783. Bugbot is set up for automated code reviews on this repo. Configure here.