fix: Error state on Item Card (M2-9441) - #2098
Merged
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
farmerpaul
approved these changes
Jun 25, 2025
farmerpaul
left a comment
Contributor
There was a problem hiding this comment.
I don't quite understand why this fixes the issue, but it does.
Contributor
Author
|
@farmerpaul Had do to some digging to figure out why. Turns out in styled-components, each CSS property declaration in the template string needs to be terminated with a semicolon, but also each line of the template literal expression needs to be terminated with a semicolon as part of the JavaScript syntax. When moving the semicolon inside, it becomes part of the CSS string, but the overall template literal expression doesn't have a terminating semicolon, breaking the styled-component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixorfeaturebranches intodeveloporreleasebranches viaSquash and Merge(to keep clean history)📝 Description
🔗 Jira Ticket M2-9441
This PR fixes an issue where after clicking "Save & Publish" on the applet editor screen, editing items, if an item had errors, the corresponding card wouldn't reflect this in its styling
🪤 Peer Testing
error_container(error[90]))