feat: Allow rename of MERIT tasks (M2-10595) - #2206
Merged
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sricharan-varanasi
left a comment
sricharan-varanasi
left a comment
Contributor
There was a problem hiding this comment.
Looks Good , with a minor question :
data-testid in NameDescription is hardcoded to "builder-activity-flanker-common". This is a pre-existing issue in NameDescription.tsx, the data-testidreferences "flanker" even when used for MERIT tasks. Similarly, NameDescriptionContent.tsx uses "builder-activity-flanker" as its dataTestid prefix.
Is this something to consider?
Contributor
Author
aweiland
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-10595
Changes include:
<NameDescription />to enable editing MERIT task name and description.📸 Screenshots
✏️ Notes
I edited a MERIT task name and refreshed to confirm that the new name was persisted.