feat: password requirements admin (M2-10506) - #2207
Merged
Merged
Conversation
sricharan-varanasi
added
the
Do not merge
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sricharan-varanasi
force-pushed
the
feature/password-requirements-admin
branch
from
April 7, 2026 21:15
7fc3d57 to
5519205
Compare
sricharan-varanasi
removed
the
Do not merge
sricharan-varanasi
changed the title
adeiji
reviewed
Apr 9, 2026
adeiji
approved these changes
Apr 9, 2026
adeiji
left a comment
adeiji
left a comment
Contributor
There was a problem hiding this comment.
Everything looks great! Just left one comment/question about using constants.
divbzero
approved these changes
Apr 9, 2026
divbzero
left a comment
divbzero
left a comment
Contributor
There was a problem hiding this comment.
@sricharan-varanasi I left several comments: 2 of them are [Important] to fix, while the rest are minor and you can use your judgment on whether to clean up.
Going to Approve but make sure you fix the 2 [Important] comments before merging.
divbzero
reviewed
Apr 9, 2026
divbzero
added a commit
to ChildMindInstitute/mindlogger-backend-refactor
that referenced
this pull request
Apr 9, 2026
Match error messages in ChildMindInstitute/mindlogger-admin#2207.
divbzero
added a commit
to ChildMindInstitute/mindlogger-backend-refactor
that referenced
this pull request
Apr 13, 2026
…2038) 🔗 [Jira Ticket M2-10505](https://mindlogger.atlassian.net/browse/M2-10505) Changes include: - Validate caseless characters in passwords as both uppercase and lowercase. This is a follow-up to pull request #2036. After thinking through @jodybrookover’s comments, seems to make sense to allow caseless characters in passwords to validate as both uppercase and lowercase letters. There tend to be more caseless characters than uppercase or lowercase letters, and this matches the behavior already implemented on the frontend with: - ChildMindInstitute/mindlogger-admin#2207 - ChildMindInstitute/mindlogger-app-refactor#1089 - ChildMindInstitute/mindlogger-web-refactor#719
divbzero
approved these changes
Apr 20, 2026
…w error message on submit when password field is empty
…asswords with only whitespace
…interpolation and added isFirstTimeTyping to useEffect dependency array
…ssword form when new password was empty
divbzero
approved these changes
Apr 24, 2026
divbzero
left a comment
divbzero
left a comment
Contributor
There was a problem hiding this comment.
New changes look good! Should be ready to merge as long as we’re good with testing.
Merged
1 task
…ops rather then constant in PasswordRequirementsSection.tsx
divbzero
added a commit
to ChildMindInstitute/mindlogger-backend-refactor
that referenced
this pull request
Apr 27, 2026
🔗 [Jira Ticket M2-10505](https://mindlogger.atlassian.net/browse/M2-10505) Changes include: - Reject passwords that contain standard emoji or regional indicators. This is a follow-up to pull requests #2036 and #2038 that brings backend password validation in line with what @adeiji implemented for emojis on the front end in: - ChildMindInstitute/mindlogger-admin#2207 - ChildMindInstitute/mindlogger-app-refactor#1089 - ChildMindInstitute/mindlogger-web-refactor#719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixorfeaturebranches intodeveloporreleasebranches viaSquash and Merge(to keep clean history)📝 Description
🔗 Jira Ticket M2-10506
Changes include:
🪤 Peer Testing
Open the Sign Up form and enter
abcdefghij.Expected outcome: after a short delay, the password field shows a validation error; the tooltip shows minimum length and no spaces as met, but the character-type requirement is not met.
Replace it with
Abcdef123!.Expected outcome: the validation error clears and the tooltip shows the password meets the minimum length and at least 3 character types.
Enter
Abcd 1234!.Expected outcome: the whitespace rule fails and the tooltip shows the no-spaces requirement as not met.
Open the Recover Password form and repeat the invalid and valid password checks above.
Expected outcome: Recover Password matches the same validation and tooltip behavior as Sign Up.
Open the Login form and enter a 6-character password such as
Pass1!.Expected outcome: no min-length validation error. Enter a 5-character password & a min-length error appears. The form still requires a password and rejects passwords with spaces.
On Sign Up or Recover Password, try a password with accented letters such as
Éclair123!a.Expected outcome: accented uppercase and lowercase letters are counted correctly toward the character-type checks.
✏️ Notes