Skip to content

fix: Remove created_at filtering (M2-9658) - #1931

Merged
jodybrookover merged 10 commits into
developfrom
fix/M2-9658-remove-created-at-filtering
Sep 9, 2025
Merged

fix: Remove created_at filtering (M2-9658)#1931
jodybrookover merged 10 commits into
developfrom
fix/M2-9658-remove-created-at-filtering

Conversation

@andrevitalb

@andrevitalb andrevitalb commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

📝 Description

🔗 Jira Ticket M2-9658

This PR removes the created_at filtering from the existing answers check when submitting answers. This specific filtering was causing issues when submitting answers locally through the mobile app due to this check relying on exact timestamp matching, which wasn't allowing for answers to be submitted.

Since we are already filtering by applet_id, activity_id and submit_id, the desired behavior will still be maintained.

Some potential edge cases were evaluated:

  1. Resubmission attempts: If a user attempts to submit an answer multiple times (could be due to network issues), the submit_id should remain consistent across attempts, so we’d still be catching those.

  2. Multiple submissions for same activity: If a user has multiple submissions for the same activity, each of those will have a different submit_id.

Since we’d still check for submit_id (which is unique), we can be confident that this check is sufficient for uniquely identifying submissions.

🪤 Peer Testing

In order to test these specific changes, submitting any activity via both the web and mobile app should succeed without issues (no "Unstable internet connection" on mobile).

📝 Notes

Extra cleanup work will be needed to remove the actual created_at parameter from the input schema (AnswersCheck) once the mobile app PR has been merged

@andrevitalb
andrevitalb requested a review from aweiland August 15, 2025 17:49
@github-actions

github-actions Bot commented Aug 15, 2025

Copy link
Copy Markdown

➡️ Preview environment failed to be destroyed

@aweiland aweiland added the Ready to merge This code ready to merge label Aug 20, 2025
@jodybrookover

Copy link
Copy Markdown
Contributor

Can someone confirm this will continue to work for old mobile clients since we can't guarantee all users will ever update.

@jodybrookover
jodybrookover merged commit 5a8e5fd into develop Sep 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge This code ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants