fix: Remove created_at filtering (M2-9658) - #1931
Merged
Merged
Conversation
Additional filtering by applet, activity and submit or user id is used
|
➡️ Preview environment failed to be destroyed |
aweiland
approved these changes
Aug 18, 2025
1 task
aweiland
approved these changes
Aug 27, 2025
Contributor
|
Can someone confirm this will continue to work for old mobile clients since we can't guarantee all users will ever update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-9658
This PR removes the
created_atfiltering from the existing answers check when submitting answers. This specific filtering was causing issues when submitting answers locally through the mobile app due to this check relying on exact timestamp matching, which wasn't allowing for answers to be submitted.Since we are already filtering by
applet_id,activity_idandsubmit_id, the desired behavior will still be maintained.Some potential edge cases were evaluated:
Resubmission attempts: If a user attempts to submit an answer multiple times (could be due to network issues), the
submit_idshould remain consistent across attempts, so we’d still be catching those.Multiple submissions for same activity: If a user has multiple submissions for the same activity, each of those will have a different
submit_id.Since we’d still check for
submit_id(which is unique), we can be confident that this check is sufficient for uniquely identifying submissions.🪤 Peer Testing
In order to test these specific changes, submitting any activity via both the web and mobile app should succeed without issues (no "Unstable internet connection" on mobile).
📝 Notes
Extra cleanup work will be needed to remove the actual
created_atparameter from the input schema (AnswersCheck) once the mobile app PR has been merged