Skip to content

fix: activity reappearance across versions (M2-9510) - #1932

Merged
sricharan-varanasi merged 5 commits into
developfrom
activity-reappear-make-version-optional
Sep 5, 2025
Merged

fix: activity reappearance across versions (M2-9510)#1932
sricharan-varanasi merged 5 commits into
developfrom
activity-reappear-make-version-optional

Conversation

@sricharan-varanasi

@sricharan-varanasi sricharan-varanasi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor
  • Tests for the changes have been added
  • Related documentation has been added / updated
  • For new features, QA automation engineers have been tagged
  • OSS packages added to
    Curious open source credit page

📝 Description

🔗 Jira Tickets:

Changes include:

  • Updated backend logic to return completions across all versions when version param is not passed
  • Explicit version filtering is preserved
  • Unit tests added to validate all version behaviors

🪤 Peer Testing

  • Scenario:

    • Submit a response on V1
    • Bump to V2 and submit again
    • Validate /answers/applet/{id}/completions:
      • version=V1 → returns V1 only
      • version=V2 → returns V2 only
      • No version → returns both

    Expected: No completed activity reappears unnecessarily

✏️ Notes

  • Shared fix for both app and web
  • Related frontend PR (web) will follow separately

@github-actions

github-actions Bot commented Aug 18, 2025

Copy link
Copy Markdown

➡️ Preview environment failed to be destroyed

Comment thread src/apps/answers/crud/answers.py Outdated
Comment thread src/apps/answers/tests/test_answers_version_optional.py Outdated
@sricharan-varanasi
sricharan-varanasi force-pushed the activity-reappear-make-version-optional branch 3 times, most recently from a57a16e to 02c5cff Compare August 21, 2025 16:00
Comment thread src/apps/answers/tests/test_answers.py
Comment thread src/apps/answers/crud/answers.py Outdated
Comment thread src/apps/answers/crud/answers.py Outdated
Comment thread src/apps/answers/tests/test_answers.py Outdated
@sricharan-varanasi sricharan-varanasi changed the title fix: activity reappearance across versions (M2-9510, M2-8170) fix: activity reappearance across versions (M2-9510) Aug 26, 2025
Comment thread src/apps/answers/crud/answers.py Outdated
Comment thread src/apps/answers/tests/test_answers.py
Comment thread src/apps/answers/tests/test_answers.py Outdated
Comment thread src/apps/answers/tests/test_answers.py Outdated
Comment thread src/apps/answers/service.py Outdated
Comment thread src/apps/answers/api.py Outdated
Comment thread src/apps/answers/api.py Outdated
@sricharan-varanasi
sricharan-varanasi force-pushed the activity-reappear-make-version-optional branch from 484e726 to 5ab5e5c Compare September 2, 2025 13:19
Comment thread src/apps/answers/crud/answers.py
@sricharan-varanasi
sricharan-varanasi force-pushed the activity-reappear-make-version-optional branch from 5ab5e5c to 183554e Compare September 2, 2025 15:58
@sricharan-varanasi
sricharan-varanasi dismissed andrevitalb’s stale review September 2, 2025 17:25

André is not part of the organization, I have made all the changes requested by André

@sricharan-varanasi
sricharan-varanasi merged commit 1e48b65 into develop Sep 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants