feat : added email subjects (M2-9301, M2-9726, M2-9731) - #1945
Merged
Conversation
|
➡️ Preview environment failed to be destroyed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curious open source credit page
📝 Description
🔗 Jira Ticket M2-9301
🔗 Jira Ticket M2-9726
🔗 Jira Ticket M2-9731
This PR removes hardcoded email subjects for reset password and assignment notifications, invitations and replaces them with localized text templates. This aligns subject handling with how email bodies are already localized, making it easier to add new languages without code changes.
Changes include:
src/apps/mailing/static/subjects/:reset_password_en.txt,reset_password_fr.txt,reset_password_el.txt,reset_password_es.txt,reset_password_pt.txtassignment_notification_en.txt,assignment_notification_fr.txt,assignment_notification_el.txt,assignment_notification_es.txt,assignment_notification_pt.txtinvitation_en.txt,inviatation_fr.txt,invitation_el.txt,invitation_es.txt,invitation_pt.txtMailingServiceto support loading localized .txt subject templates with fallback to English.PasswordRecoveryService.send_password_recoveryto use the new template-based subject instead of hardcoded dict.ActivityAssignmentService.send_email_notificationto use the new template-based subject instead of_get_email_assignment_subject._get_email_assignment_subjectandget_locallized_email_subjectfunctions.🪤 Peer Testing
✏️ Notes
.txtfiles must be packaged for deployment