Conversation
- Add null check after ActivitiesCRUD.get_by_id() to raise ActivityDoeNotExist - Update test assertion to expect HTTP 404 instead of generic != 200
divbzero
approved these changes
Apr 10, 2026
divbzero
left a comment
Contributor
There was a problem hiding this comment.
@sricharan-varanasi The fix looks good and works on my machine. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ActivitiesCRUD.get_by_id()- raisesActivityDoeNotExist(404) when activity is not foundHTTP 404instead of!= 200Why
Previously, fetching a deleted activity without a version would cause a
NullPointerErroror undefined behavior downstream (attemptingschema.applet_idonNone). Now it returns a proper 404.Notes
ActivityDoeNotExistalready existed inapps/activities/errors.pyactivity_retrieve(the versioned path was already safe)