feat: AuditEvent data model (M2-10698) - #2046
Merged
Merged
Conversation
aweiland
reviewed
May 5, 2026
I removed by_alias=True in commit f5a8a01 but serialize_by_alias=True wasn't actually set on PublicModel. Set here on AuditEvent instead.
sricharan-varanasi
requested changes
May 5, 2026
adeiji
reviewed
May 5, 2026
adeiji
left a comment
adeiji
left a comment
Contributor
There was a problem hiding this comment.
It looks good! I do agree with the comment that Sri made about mapping fields as a list.
This reverts commit 81cf14b. Conflicts: src/apps/audit/domain.py
sricharan-varanasi
approved these changes
May 5, 2026
sricharan-varanasi
left a comment
sricharan-varanasi
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-10698
Changes include:
AuditEventdata modelaudit.logstubThis provides a common interface that we can work against for M2-10697, M2-10698, M2-10699, and M2-10700.
✏️ Notes
We try to use standard Elastic Common Schema (ECS) fields where possible.