Skip to content

Fix #7024 variable coercion with custom interface-typed filter fields#9266

Open
michaelstaib wants to merge 1 commit intomainfrom
mst/issue-7024
Open

Fix #7024 variable coercion with custom interface-typed filter fields#9266
michaelstaib wants to merge 1 commit intomainfrom
mst/issue-7024

Conversation

@michaelstaib
Copy link
Member

Fixes #7024

Summary

  • adds a regression test reproducing the custom filter variable coercion scenario from the issue
  • avoids interface instantiation in DictionaryToObjectConverter when the input value is a dictionary
  • keeps dictionary representation for interface targets so variable-based filter input behaves like inline filter input

Test Commands

  • dotnet test src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/HotChocolate.Data.Filters.InMemory.Tests.csproj --filter "FullyQualifiedName~Issue7024Tests" --nologo
  • dotnet test src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/HotChocolate.Data.Filters.InMemory.Tests.csproj --filter "FullyQualifiedName~QueryableFilterVisitorListTests|FullyQualifiedName~QueryableFilterVisitorVariablesTests|FullyQualifiedName~Issue7024Tests" --nologo

Results

  • Passed on net8.0, net9.0, and net10.0.

@github-actions
Copy link
Contributor

Fusion Gateway Performance Results

Progress: 0/6 benchmarks completed — this report updates as each job finishes.

Simple Composite Query

Req/s Err%
Constant 2 (50 VUs) pending pending
Ramping 2 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 2 pending pending pending pending pending pending
Ramping 2 pending pending pending pending pending pending

Deep Recursion Query

Req/s Err%
Constant 2 (50 VUs) pending pending
Ramping 2 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 2 pending pending pending pending pending pending
Ramping 2 pending pending pending pending pending pending

Variable Batching Throughput

Req/s Err%
Constant 2 (50 VUs) pending pending
Ramping 2 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 2 pending pending pending pending pending pending
Ramping 2 pending pending pending pending pending pending

Runner 2 = benchmarking-2

Run 22500876388 • Commit caac859 • Fri, 27 Feb 2026 19:34:30 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in variable coercion when using custom filter in query

1 participant