Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions src/HotChocolate/Core/src/Types/Configuration/TypeDiscoverer.cs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using System.Globalization;
using System.Text;
using HotChocolate.Properties;
using HotChocolate.Types;
using HotChocolate.Types.Descriptors;
Expand Down Expand Up @@ -238,22 +240,46 @@ private void CollectErrors()

if (_errors.Count == 0 && _typeRegistrar.Unresolved.Count > 0)
{
foreach (var unresolvedReference in _typeRegistrar.Unresolved)
var message = new StringBuilder();

// the unresolved references are stored in an unordered set, so we order
// them deterministically to keep the produced error sequence stable.
foreach (var unresolvedReference in
_typeRegistrar.Unresolved.OrderBy(r => r.ToString(), StringComparer.Ordinal))
{
var types = _typeRegistry.Types.Where(
t => t.Dependencies.Select(d => d.Type)
.Any(r => r.Equals(unresolvedReference))).ToList();

var path = TypeInferencePathBuilder.Build(_typeRegistry, unresolvedReference);

message.Clear();

message.AppendFormat(
CultureInfo.InvariantCulture,
TypeResources.TypeRegistrar_TypesInconsistent,
unresolvedReference);

if (path.HasValue)
{
message.Append(Environment.NewLine);
message.Append(Environment.NewLine);
message.Append(path.Value.Short);
}

var builder =
SchemaErrorBuilder.New()
.SetMessage(
TypeResources.TypeRegistrar_TypesInconsistent,
unresolvedReference)
.SetMessage(message.ToString())
.SetExtension(
TypeErrorFields.Reference,
unresolvedReference)
.SetCode(ErrorCodes.Schema.UnresolvedTypes);

if (path.HasValue)
{
builder.SetExtension(TypeErrorFields.Path, path.Value.Expanded);
}

if (types.Count == 1)
{
builder.SetTypeSystemObject(types[0].Type);
Expand Down
Loading
Loading