Skip to content

Conversation

@IcemarkUK
Copy link
Member

No description provided.

@IcemarkUK IcemarkUK requested a review from Copilot June 15, 2025 23:17
@IcemarkUK IcemarkUK self-assigned this Jun 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the "#306 don't show dedication every time" feature by introducing a controlled frequency for showing the dedication screen. Key changes include updating configuration macro usage, adding a new dedication frequency mechanism with bumpDedication() and dedication_screen_count, and applying these changes across the splashscreen and panel modules.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
main/midnight/Source/system/storymanager.cpp Updated config checks to use macros consistently.
main/midnight/Source/system/settingsmanager.h Increased CONFIG_VERSION and added dedication frequency definitions and bumpDedication().
main/midnight/Source/system/settingsmanager.cpp Reworked constructor and persistence for dedication_screen_count; added bumpDedication() method.
main/midnight/Source/system/panelmanager.cpp Updated config usage from CONFIG to SETTINGS where appropriate.
main/midnight/Source/system/moonring.h Added SETTINGS macro definition alongside CONFIG.
main/midnight/Source/panels/panel_splashscreen.cpp Changed dedication screen display logic to call bumpDedication().
main/midnight/Source/panels/panel_map_detailed.cpp Updated debug flag check to use CONFIG macro.
main/midnight/Source/panels/panel_dedication.cpp Updated screen transition checks to use SETTINGS macro.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants