fix(webhook): document response_mode as required; drop dead default#66
Merged
Conversation
The parser already requires webhook.response_mode (validate_webhook! checks method/url/response_mode). Make that explicit and remove the silent fallback so server and CLI agree (no default divergence). - SPEC.md: webhook section + matrix mark response_mode REQUIRED (no default) - webhook.rb: remove the dead `|| "callback"` fallback - parser spec: add cases — missing response_mode rejected, invalid value rejected, all-required-fields accepted (77 examples, 0 failures) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the webhook
response_modecontract explicit and divergence-free (pairs with Chosen9115/opensop-cli#16).validate_webhook!already requiresresponse_mode; this documents it as required (no default) inSPEC.md(webhook section + capability matrix) and removes the now-dead|| "callback"fallback inwebhook.rb.sync/ runtime-callbacksplit.Self-rating
Test plan
bundle exec rspec spec/services/opensop/definition_parser_spec.rb→ 77 examples, 0 failures.🤖 Generated with Claude Code