-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add tweak to block Logitech Download Assistant auto-install #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChrisTitusTech
merged 2 commits into
ChrisTitusTech:main
from
malinfossum:feat/block-logi-download-assistant
Sep 2, 2026
+35
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
icaclsreturns nonzero—for example because the directory ACL cannot be modified—this newthrowstill does not make the tweak fail:Invoke-WinUtilScript.ps1:32-49catches the resulting runtime exception without rethrowing or returning failure, after whichInvoke-WinUtilTweaks.ps1:84unconditionally logs that the tweak completed. Fresh evidence in the hardened version is that the newly added exit-code check is therefore swallowed by the existing wrapper, so callers can still treat an unapplied block as successful; propagate a failure result so completion is not reported.AGENTS.md reference: AGENTS.md:L102-L102
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the standard execution model across all WinUtil tweaks.
Invoke-WinUtilScriptcatches runtime exceptions so errors are logged without crashing the runner or aborting other queued tweaks. Propagating tweak failure status toInvoke-WinUtilTweakswould require changes to the core execution engine across the entire codebase, which is out of scope. You can safely disregard this!