refactor: optimize remove duplicated properties#852
Open
vladitasev wants to merge 4 commits into
Open
Conversation
Owner
|
Thanks @vladitasev! |
Author
|
Hey @ChristianMurphy |
ChristianMurphy
approved these changes
Apr 21, 2022
ChristianMurphy
left a comment
Owner
There was a problem hiding this comment.
Thanks @vladitasev!
LGTM, an ideas on how to test the performance characteristics to ensure no regressions come up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
removeDuplicatedValuesconfiguration setting is set totrue, it is unavoidable to have two embedded loops to remove duplicates, as both the props and the values must be compared.However, if only
removeDuplicatedPropertiesis set totrue, then duplicates can be removed with only one loop - iterate from the last node to the first, keep the first occurrence of each prop (as it will be the last in the CSS selector), and remove all others.For large, programmatically generated selectors, most commonly
:root { ... }and hundreds of CSS variables inside, this optimization can reduce the time needed by the plugin by a minute or more.