Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ci.yml, assertSame and fix PHPStan #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve ci.yml, assertSame and fix PHPStan #34

wants to merge 1 commit into from

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented May 12, 2022 •
edited
Loading

Changed log

  • Using the PHP-CS-Fixer 2.19.0 version to be compatible with the current .php_cs.dist file.
  • By default, the latest docker:/oskarstark/php-cs-fixer-ga version is 3.x.
  • Using the assertSame to let assertion be strict.
  • Fix the comment codes via PHPStan analyzing issue.

@peter279k peter279k changed the title Improve ci.yml and assertSame Improve ci.yml, assertSame and fix PHPStan May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peter279k