Fix 4GB part size limit in hori_buffer_len#9
Open
draimundo wants to merge 3 commits intoChristianSteger:mainfrom
Open
Fix 4GB part size limit in hori_buffer_len#9draimundo wants to merge 3 commits intoChristianSteger:mainfrom
draimundo wants to merge 3 commits intoChristianSteger:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building HORAYZON on my 64-bit machine according to the
README, theintare interpreted asint32_t.This is not an issue for most variables, however for the buffer length specified by
hori_buffer_size_maxinhorayzon.horizon.horizon_gridded, which then gets used to specify the sizes of the parts in bits, this means I am limited to (2^31-1) bits, which is about 4GB. In some usecases (including mine), this means generating hundreds of files, which is unwanted.I propose specifying the type of
hori_buffer_lento avoid this.