tests: streamline Helm chart tests with assertChartData function#195
Closed
xakraz wants to merge 1 commit into
Closed
tests: streamline Helm chart tests with assertChartData function#195xakraz wants to merge 1 commit into
assertChartData function#195xakraz wants to merge 1 commit into
Conversation
- Remove detailed comments listing charts and add comments clarifying assertions on chart and image counts. - Introduce `assertChartData` function for chart and image count validation, replacing repetitive test logic. - Refactor tests to utilize `assertChartData`, streamlining assertion logic across multiple Helm chart tests. Signed-off-by: Xavier Krantz <xakraz@gmail.com>
This was referenced Feb 26, 2026
Owner
|
Hey, Thanks for the PRs! I have fixed CI in another PR, please see if that fixes the issue and if not reopen this PR. |
Author
|
After rebasing other PRs on your 
https://github.com/DataDome-OSS-contrib/helmper/actions/runs/22786049115/job/66102937257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR tries to fix the current failing CI 🤞🏻
Changes
assertChartDatafunction for chart and image count validation, replacing repetitive test logic.assertChartData, streamlining assertion logic across multiple Helm chart tests.Signed-off-by: Xavier Krantz xakraz@gmail.com