Skip to content

fix(jsonata): add JSONata syntax validation and support#172

Merged
ChristopheBougere merged 3 commits into
ChristopheBougere:mainfrom
aidanprior:feature/jsonata-syntax-validation
May 6, 2025
Merged

fix(jsonata): add JSONata syntax validation and support#172
ChristopheBougere merged 3 commits into
ChristopheBougere:mainfrom
aidanprior:feature/jsonata-syntax-validation

Conversation

@aidanprior
Copy link
Copy Markdown
Contributor

@aidanprior aidanprior commented May 1, 2025

  • Introduced JSONata syntax validation in the validator.
  • Added new error code for invalid JSONata syntax.
  • Included 'jsonata' dependency.
  • Created a handful of simple tests.

CLOSES #171

- Introduced JSONata syntax validation in the validator.
- Added new error code for invalid JSONata syntax.
- Included 'jsonata' dependency.
- Created a handfull of simple tests.

CLOSES ChristopheBougere#171
Copy link
Copy Markdown
Owner

@ChristopheBougere ChristopheBougere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and the tests cases!
Looks globally good to me, could you just fix the lint error?

@massfords would you like to have a look ?

Comment thread src/checks/jsonata-syntax-validator.ts
Comment thread src/checks/jsonata-syntax-validator.ts Outdated
Copy link
Copy Markdown
Collaborator

@massfords massfords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions in your test files

Comment thread src/__tests__/definitions/invalid-jsonata-syntax-mismatched-parens.json Outdated
Comment thread src/__tests__/definitions/invalid-jsonata-syntax-variable-reference.json Outdated
- remove duplicate test: invalid-jsonata-syntax-variable-reference.json
- fix typo in invalid-jsonata-syntax-mismatched-parens.json
@ChristopheBougere ChristopheBougere merged commit 43ddab0 into ChristopheBougere:main May 6, 2025
1 check passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2025

🎉 This PR is included in version 3.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate JSONata Syntax

3 participants