You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not super proud of it but I'm using Regex to identify the custom search query pattern 🤦
I can elaborate it to enable search on the basis of protocol and other factors but thought of getting this reviewed.
Would like to share some feedback as well.
It feels a bit weird to type method search. As a user I would prefer to have some filtering view with checkboxes, like the one I described in the issue you referenced. This way users won't be confused by what they can type in search view and have a visible set of filters right away. With current implementation you showed I feel like most users won't even notice that there is such functionality.
@vbuberen
I agree that discovery of the method search in this pr is something that would require developer education.
Maybe, I misunderstood what @cortinico meant in this comment.
I also understand that you'd wanted to expose the filters using a BottomSheet.
This is what I'd worked on before I thought of implementing the changes in this PR.
@vbuberen I agree that discovery of the method search in this pr is something that would require developer education. Maybe, I misunderstood what @cortinico meant in this comment. I also understand that you'd wanted to expose the filters using a BottomSheet. This is what I'd worked on before I thought of implementing the changes in this PR.
Still a Work In Progress. But this is where I'm at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
@cortinico Not sure if this is what you had in mind

📄 Context
Refer #286
📝 Changes
I'm not super proud of it but I'm using Regex to identify the custom search query pattern 🤦
I can elaborate it to enable search on the basis of protocol and other factors but thought of getting this reviewed.
📎 Related PR
🚫 Breaking
None
🛠️ How to test
Unit test included
⏱️ Next steps