fix: golint installation for golang version above 1.26#382
Open
david-montano-circleci wants to merge 1 commit intomainfrom
Open
fix: golint installation for golang version above 1.26#382david-montano-circleci wants to merge 1 commit intomainfrom
david-montano-circleci wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the
Dockerfile.templateto implement a conditional installation strategy forgolangci-lintbased on the Go version. For environments using Go 1.26 or higher, the linter is now compiled from source; older versions continue to use the binary installation script.Fixes #374
Reasons
golangci-lintfrom source usinggo installfor Go 1.26+ ensures the binary is perfectly linked with the container's specific toolchain, preventing potential execution issues with pre-compiled binaries on newer runtimes.MINOR_VERvariable to make the shell conditional logic cleaner and more maintainable./tmp/golangci-lint-src) immediately after compilation to keep the image layer size optimized.Checklist
Please check through the following before opening your PR. Thank you!
Dockerfile.templatefile only