Skip to content

Fixes bash command error when DESTDIR is a non-path directory #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frshwtr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes bash command error when DESTDIR is a non-path directory #431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5487622
Fixes bash command error when DESTDIR is a non-path directory
Jun 12, 2020
4d8be28
Merge branch 'master' into fix-command-for-custom-dest-dir
frshwtr Jun 16, 2020
330d65b
Merge branch 'master' into fix-command-for-custom-dest-dir
corinnesollows Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ curl -sL --retry 3 "${RELEASE_URL}" | tar zx --strip 1
echo "Installing to $DESTDIR"
install circleci "$DESTDIR"

command -v circleci
command -v "$DESTDIR"circleci
Copy link
Contributor

@jvincent42 jvincent42 Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to remove any potential trailing / in DESTDIR and force a / before the binary name.

Suggested change
command -v "$DESTDIR"circleci
command -v "${DESTDIR%/}"/circleci


# Delete the working directory when the install was successful.
rm -r "$SCRATCH"