Dockerfile: Use CMD for cli arguments#101
Closed
cmrigney wants to merge 1 commit intoCircleCI-Public:mainfrom
Closed
Dockerfile: Use CMD for cli arguments#101cmrigney wants to merge 1 commit intoCircleCI-Public:mainfrom
cmrigney wants to merge 1 commit intoCircleCI-Public:mainfrom
Conversation
Author
|
My colleague opened a PR with the same changes, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
start:ssetoCMDin the Dockerfile so that it can be overridden in case a user wants to usestdioinstead. E.g.docker run --rm mcp/circleci stdioAlso, stdio is needed (for now) for us to update the entry in the Docker catalog: https://hub.docker.com/mcp/server/circleci/overview