Skip to content

Conversation

@Prerna-0202
Copy link
Member

@Prerna-0202 Prerna-0202 commented Dec 21, 2021

Fixes #28

Ref #461

Changes done:

I have corrected the values in karnaugh Map table as mentioned in issue#28 for all the input values of k ...

  • Task 1

Screenshots

Before:-
Screenshot (85)
Screenshot (84)

After:-
Screenshot (82)
Screenshot (83)

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
  • Tried Squashing the commits into one

@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for vigilant-nightingale-2f57b2 ready!

🔨 Explore the source changes: 0584b1e

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/61c2203f285b56000a6f241a

😎 Browse the preview: https://deploy-preview-601--vigilant-nightingale-2f57b2.netlify.app

@Prerna-0202
Copy link
Member Author

@manjotsidhu, Can you please review my pr once...

Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to implement this without needing to hardcode the tables ? The previous implementation though broken had less lines of code and was scalable.

@Prerna-0202
Copy link
Member Author

Prerna-0202 commented Dec 22, 2021

Is it possible to implement this without needing to hardcode the tables ? The previous implementation though broken had less lines of code and was scalable.

Okay, Thanks for reviewing I will try to do it in that way...

Copy link
Member

@ayan-biswas0412 ayan-biswas0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to generate the numbers without hardcoding them? @Prerna-0202
It will be better if it is implemented in code to generate the values rather than hardcoding

@Prerna-0202
Copy link
Member Author

@manjotsidhu @ayan-biswas0412, I have tried but not getting any other way to do this without hardcoding the tables...If you have any idea please share...

@manjotsidhu
Copy link
Member

@vedant-jain03 can you help @Prerna-0202 with this ?

@vedant-jain03
Copy link
Member

vedant-jain03 commented Jan 6, 2022

@vedant-jain03 can you help @Prerna-0202 with this ?

Yeah sure, I think we can fill the array of each by recognizing the pattern. Provide me some time for it.

@Malavi1
Copy link

Malavi1 commented Feb 16, 2023

In parallel I will also try to figure out the pattern behind this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

K map method

5 participants