attachment_filename is replaced with download_name - #8
Open
amit-raut wants to merge 1 commit into
Open
Conversation
…ile method Updated code for successful downloading of the PCAP file. Currently the code is based on the deprecated method parameter `attachment_filename`. `attachment_filename` is replaced with `download_name` in Flask's send_file method (Please see pallets/flask#4753 for more details). Thanks, Amit Raut
passwa11
added a commit
to passwa11/Re2Pcap
that referenced
this pull request
Feb 22, 2023
fix TypeError: send_file() got an unexpected keyword argument 'attachment_filename' from Cisco-Talos#8 and pallets/flask#4753
amit-raut
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated code for successful downloading of the PCAP file. Currently the code is based on the deprecated method parameter
attachment_filename.attachment_filenameis replaced withdownload_namein Flask's send_file method (Please see pallets/flask#4753 for more details).I would love to maintain this project but since it was removed and re-added under Cisco-Talos, I lost write ability to this repository. Please add write access to me for this repo (or I'll have to go through the pull requests every time I need to make changes to this repo)
Thanks,
Amit Raut