Add win32_compat dependency to libraries using pthread.h - #1520
Merged
Conversation
zaddach
force-pushed
the
add_win32_compat_dependency
branch
from
June 19, 2025 13:32
0da9a36 to
5aa8d0d
Compare
zaddach
force-pushed
the
add_win32_compat_dependency
branch
4 times, most recently
from
August 6, 2025 16:21
2a25035 to
e5870ae
Compare
val-ms
force-pushed
the
add_win32_compat_dependency
branch
from
December 16, 2025 15:22
c7eff82 to
89a5860
Compare
Contributor
|
Just rebased and force-pushed to see this run through CI/CD. |
val-ms
approved these changes
Dec 16, 2025
val-ms
left a comment
val-ms
left a comment
Contributor
There was a problem hiding this comment.
CI/CD (github and jenkins) look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of intermediate libraries (such as regex, bytecode_runtime, ...) use the
pthread.hheader. On Windows, it is made available through thePThreadW32library, and those libraries need to "link" against thewin32_compatlibrary to be able to see the header.