Set UTF-8 as the default code page on the manifest - #1537
Merged
Conversation
Contributor
|
LGTM (I'm the author of #1461) |
Contributor
|
Also see #1515 where a similar solution may be desirable. |
This is available since Windows 1903 but backwards compatible. https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page Signed-off-by: Sophie0x2E <219585213+Sophie0x2E@users.noreply.github.com>
Contributor
Author
|
There is still a bug in how cross-platform log messages are handled. Moving to draft. |
Fi418
marked this pull request as draft
July 9, 2025 22:23
Contributor
Author
|
It seems to be on mprintf, that should probably be handled as a separate issue. |
Fi418
marked this pull request as ready for review
July 9, 2025 23:03
val-ms
approved these changes
Jul 25, 2025
val-ms
left a comment
val-ms
left a comment
Contributor
There was a problem hiding this comment.
Testing on my windows laptop, I was able to demonstrate the fix:
clamav-1/build on PR-1537 [$?] via △ v3.29.0
❯ cp ..\unit_tests\input\freshclam_testfiles\test-6.cvd file_öταБЬℓσ.cvd
clamav-1/build on PR-1537 [$?] via △ v3.29.0
❯ C:\Users\micasnyd\clams\clamav-1.3.1.win.x64\sigtool.exe --info .\file_öταБЬℓσ.cvd
LibClamAV Error: cl_cvdhead: Can't open file .\file_öταБЬℓσ.cvd
ERROR: cvdinfo: Can't read/parse CVD header of .\file_öτα??lσ.cvd
clamav-1/build on PR-1537 [$?] via △ v3.29.0
❯ .\install\sigtool --info .\file_öταБЬℓσ.cvd
File: .\file_öταБЬℓσ.cvd
Build time: 22 Jun 2021 21:34 -0400
Version: 6
Signatures: 14
Functionality level: 81
Builder: micasnyd
MD5: 3e249e00076b0b15bb54ced37be880c7
Digital signature: Dou6ICRT5HwLTtLNYToHsMoLnt8tdcQOEECp/INsusRs9Rz4JGWU27W76btwjszaKIHnfgfyFjHzlsYJxTFZoeYFLyaC1nd+SNSWaMyKeNvzcTrtxKbc5WKs04ORp923pFkqymRhFNrRupa8tVyrp9XN9WbdxVJKZNHzB6npPPj
Verification OK.Thank you @Sophie0x2E and sorry for the lag time with review.
jhumlick
pushed a commit
to jhumlick/clamav
that referenced
this pull request
Nov 4, 2025
…los#1537) Set UTF-8 as the default code page on the manifest This is available since Windows 1903 but backwards compatible. https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page Add manifest to other binaries --------- Signed-off-by: Sophie0x2E <219585213+Sophie0x2E@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is available since Windows 1903 but backwards compatible.
https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page
For older versions the changes from #1461 could be used.
Fixes #1440.