libclamav: Add PDF stats for metadata collection. - #1546
Merged
Conversation
val-ms
requested changes
Dec 16, 2025
More PDF statistics were requested for feature parity. If metadata collection is enabled, the following additional PDF statistics will be collected: - Number of Automatic Actions - Number of Streams - Number of Objects - Number of Object Streams - Number of Trailers - Number of URIs - Number of Xrefs Additionally, some of the parsing logic was fixed during testing of these features. CLAM-2820
val-ms
force-pushed
the
CLAM-2540-add-pdf-metadata
branch
from
December 16, 2025 21:17
700b5d9 to
20f15cc
Compare
Contributor
|
I was able to reproduce the failed windows test on my local windows machine. It is concerning, since there is no OS-specific logic in the pdf parser that I'm aware of which would cause it not to run that I'm going to have to diff the debug logs on Windows vs another platform, or else debug-step through with breakpoints to find out what's different. |
val-ms
approved these changes
Jan 21, 2026
val-ms
left a comment
val-ms
left a comment
Contributor
There was a problem hiding this comment.
I am now unable to reproduce the failed windows build locally, and it passed on both github and jenkins CI/CD. The tests ran okay as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More PDF statistics were requested for feature parity. If metadata collection is enabled, the following additional PDF statistics will be collected:
Additionally, some of the parsing logic was fixed during testing of these features.
CLAM-2820